Repository navigation
FOMO · Mobula showed a two-letter fallback: it was in no site registry - #3241
Merged
Merged
Conversation
It ranks #4 at 290 bps on the bench and renders "FM" instead of a logo, because the slug reached the spec and none of the site's registries, while pump-bridge is in four of them. The precedent was already set and its own comment says why: pump-bridge carries pump.fun's logo and brand colour because it IS pump, reached by a different rail. FOMO over Mobula is the same case, so it gets FOMO's violet, FOMO's logo and FOMO's links. brand.ts the colour, so the bar is FOMO's rather than a default providers.ts the display name logo-manifest.ts FOMO's own logo, which is on disk provider-registry the product page's url, description and handle The description says what the ROW is rather than what Mobula is: the row measures FOMO's trades over that rail, and a reader clicking it is asking about FOMO's route rather than about the bridge company. Checked both routes field by field against axiom, a row that has been on this bench for months, rather than against a list of what I just added, so anything I had not thought of would still show: spec provider, brand colour, display name, logo, product registry, and the logo file actually on disk. Both complete on all of them.
Flotapponnier
added a commit
that referenced
this pull request
Oct 24, 2026
…3273) Found reviewing my own previous PR against the precedent it should have followed. #3241 fixed the same class of gap for FOMO Mobula and had to touch four files; I touched one. Checked each: brand.ts and providers.ts carry no aggregator at all, so they are correctly empty here, but provider-registry carries kyberswap and paraswap, the same kind of provider on the same bench, and did not carry nordstern. So its row had a mark while its product page had no official link and no description. The description comes from the site's own meta tags rather than being written for it. No twitter field: none is linked anywhere on the site, and inventing a handle would point readers at an account that may not be theirs. The registry accepts a url-only entry for exactly that case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It ranks #4 at 290 bps on the bench and renders
FMinstead of a logo, because the slug reached the spec and none of the site's registries, whilepump-bridgeis in four of them.The precedent was set and its own comment says why:
pump-bridgecarries pump.fun's logo and brand colour because it is pump, reached by a different rail. FOMO over Mobula is the same case.brand.tsproviders.tslogo-manifest.tsprovider-registry.tsThe description says what the row is rather than what Mobula is: the row measures FOMO's trades over that rail, and a reader clicking it is asking about FOMO's route, not about the bridge company.
Completeness
Checked both routes field by field against
axiom— a row that has been on this bench for months — rather than against a list of what I just added, so anything I had not thought of would still show up:tsc --noEmitandpnpm validate(254 specs) green.