Repository navigation
the held row mixes two populations, it does not simply omit a fee - #3149
Merged
Merged
Conversation
The hold was right, the reason given for it was not. This row was described as measuring the destination swap with the bridge's take left out, understating the loss by a fixed 95 bps at $10 and 545 at $1. Checking the 63 swaps behind it: 40 touch the bridge router at all and only 10 are sent by pump's relayer. The rest are wallets trading their own funds on the chain, with no Solana deposit and no take, whose published loss was correct. So the row carries two populations with different cost bases, and the harness cannot yet tell which swap is which. One median over both is not a cost whichever way it leans, which is why the row stays held, but the arithmetic offered earlier applies to a subset whose size is not established and should not have been stated as the row's true loss. Spec formula and row note reworded to say that. No behaviour change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hold was right, the reason given for it was not.
The pump.fun EVM rows were described as measuring the destination swap with the bridge's take left out, understating the loss by a fixed 95 bps at $10 and 545 bps at $1.
Checking the 63 swaps behind
pump-fun-bnb:The rest are wallets trading their own funds on the chain: no Solana deposit, no take, and their published loss was correct. Four sampled by hand go to
0xccc88a9d…with no log from the router at all.So the row carries two populations with different cost bases and the harness cannot yet tell which swap is which. One median over both is not a cost whichever way it leans, which is why the row stays held. But the arithmetic offered earlier applies to a subset whose size is not established, and should not have been stated as the row's true loss.
Spec formula and row note reworded. No behaviour change, no test change: the hold itself is unchanged.