Repository navigation
Nova's product page said "(no logo)", so here is the logo - #3147
Merged
Merged
Conversation
/products/nova-markets has been live since the release, built from the registry entry, and rendering its alt text because no file backed it. Nova publishes no logo file: /logo.svg, /logo.png, /favicon.svg, /icon.svg, /apple-icon.png and four paths under assets/ all 404, and that assets/logos directory holds only the third-party marks they display (hyperbeat, hyperliquid, kinetiq). The mark is inlined twice in their homepage instead, at 44x33 and 32x24 on the same 325x240 viewBox, three paths. The larger one is taken here with its width and height stripped so it scales to whatever box the site gives it. It also goes in NEEDS_DARK_CHIP, which matters more than registering it. All three paths are #F3F3F3 on transparent, and provider-logo.tsx names that case exactly: "white-on-transparent -> invisible on white light-mode page -> dark chip". Registering the file alone would have shipped a logo nobody can see on the default paper ground, which is indistinguishable from the problem this commit is fixing. Checked by rendering it: a four-pointed star inside a lens, legible at 120px on #0f172a and nearly gone on #faf9f7, which is the chip decision confirmed rather than assumed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/products/nova-marketshas been live since the release, built automaticallyfrom the registry entry, and rendering
Nova (no logo)as its alt textbecause no file backed it.
Where the logo came from
Nova publishes no logo file.
/logo.svg,/logo.png,/favicon.svg,/icon.svg,/apple-icon.pngand four paths underassets/all 404, andtheir
assets/logos/directory holds only the third-party marks they display(hyperbeat, hyperliquid, kinetiq).
The mark is inlined in their homepage instead, twice, at 44×33 and 32×24
on the same
viewBox="37.5 80 325 240", three paths. The larger one is takenhere with
widthandheightstripped so it scales to whatever box the sitegives it.
The part that matters more than registering it
All three paths are
fill="#F3F3F3"on transparent.provider-logo.tsxnames this case in its own comment:
So it goes in
NEEDS_DARK_CHIP, not just the manifest. Registering the filealone would have shipped a logo nobody can see on the default
var(--color-paper)ground, which looks exactly like the problem this ismeant to fix.
Checked rather than assumed
Rendered at 300px: a four-pointed star inside a lens shape, clean at 120px on
#0f172aand nearly invisible on#faf9f7. That is the chip decisionconfirmed by looking, not inferred from the hex value.
Checks
tsc --noEmitclean.eslint0 errors.bun test732 pass.pnpm validate253 specs valid. The SVG parses as well-formed XML.
🤖 Generated with Claude Code