Repository navigation
the tie was in the other branch - #3084
Merged
Merged
Conversation
PR 3082 fixed the `sec` branch and the blob kept saying "Mobula (tied) ... 0.3 s" after a worker rebuild that demonstrably carried the new code. aggregator-head-lag declares unit "s", whose input is MILLISECONDS by the latency-bench convention: the stored value is 304.262 and valueInDeclaredUnit divides by 1000 only for the public JSON. The string came from the "s" branch, where `s < 10` takes one decimal. That branch now keeps two decimals below a second, so 304 ms reads 0.30 s and 327 ms reads 0.33 s and leaders() stops calling them tied. The `sec` change stays: it is the same defect waiting on any sub-second gauge. The tests now pin the values the bench actually stores rather than the ones I assumed, which is what let the first attempt pass its own suite while changing nothing on the page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3082 fixed the
secbranch and the published blob kept saying "Mobula (tied) ... 0.3 s" after a worker rebuild that demonstrably carried the new code (grep -c 's.toFixed(2)' /app/src/lib/format.tsreturned 1 inside the container).aggregator-head-lag declares unit
s, whose input is milliseconds by the latency-bench convention: the stored value is 304.262, andvalueInDeclaredUnitdivides by 1000 only for the public JSON. So the string came from thesbranch, wheres < 10takes one decimal, not fromsec.That branch now keeps two decimals below a second: 304 ms reads 0.30 s, 327 ms reads 0.33 s, and
leaders()stops calling them tied.The
secchange from #3082 stays. It is the same defect waiting on any sub-second gauge.The tests now pin the values the bench actually stores rather than the ones I assumed, which is what let the first attempt pass its own suite while changing nothing on the page. One of the new assertions was also wrong about existing behaviour (15900 ms renders "16 s", not "15.9 s") and is corrected with a note.
Gates: tsc clean, 627 tests pass.