Repository navigation
the unranked row read 0 ms, which is not a latency - #3054
Merged
Merged
Conversation
The re-run audit's pass A opened on it: Route published at exactly 0 ms p50 on 717 samples. That is my own fix from #3052 and #3053. Taking a row out of the order, I zeroed its value because the spec-declared unranked path does, and the ledger rendered "0 ms" in p50, p90 and p99. A wall-clock round trip of zero is impossible. A reader sees either a broken row or Route being instant, and the second is worse than the claim the fix was written to remove. Nothing needed the zero. citation.ts picks the leader from rows filtered on the label, the ledger pins labelled rows below the ranked field and excludes them from ranks and the field mean, and capital-hub filters on the label too. The label alone does the work. Route now keeps its measured 215 ms and sits in its own block under "Robinhood only", which is both true and useful: it is the number a reader wants once they know what it covers. Pass A also claimed the Robinhood explainer and badge named a 0 ms leader. They did not: bestPerChain carries Route at 216.209 and the page renders "at 217 ms". The finding was right about the ledger and wrong about the explainer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The re-run audit's pass A opened on it: Route published at exactly 0 ms p50 on 717 samples. That is my own fix from #3052 and #3053. Taking a row out of the order, I zeroed its value because the spec-declared
unrankedpath does, and the ledger rendered0 msin p50, p90 and p99:A wall-clock round trip of zero is impossible. A reader sees either a broken row or Route being instant, and the second is worse than the claim the fix was written to remove.
Nothing needed the zero.
citation.ts:49,60picks the leader from rows filtered on the label,ledger-table.tsx:292pins labelled rows below the ranked field and excludes them from ranks and the field mean, andcapital-hub.ts:133filters on the label too. The label alone does the work.Route now keeps its measured 215 ms and sits in its own block under "Robinhood only", which is both true and useful: it is the number a reader wants once they know what it covers.
One correction to the audit. Pass A also claimed the Robinhood explainer and badge named a 0 ms leader. They did not —
bestPerChain.robinhoodcarries Route at 216.209 and the page renders "at 217 ms". The finding was right about the ledger and wrong about the explainer.Gates: tsc clean, 603 tests pass.