Repository navigation
terminal-activity: the same 63.9% was on a second board, via the windows - #3030
Merged
Merged
Conversation
#3029 cleared the take-rate bench. The compare page still showed 63.9%, because the leaderboard board reads a different metric family: terminal_window_take_rate_pct, summed over 1d, 7d and 30d in windows.go, which had neither gate. pump.fun published 63.9% / 11.4% / 0.13% there. The arithmetic is the same defect over three windows. $910.86 of Base fees divided by $1,424.96 of Base volume, while the $40.6M Solana leg reports nothing and is correctly excluded from the ratio. Excluding it is right; using what remains as the platform's rate is not. Both gates now apply to the windows as well as the daily cells: - A day whose fee exceeds 10% of its own volume never enters a window, numerator or denominator. It is the source attributing a fee to the wrong denominator. - The all-chains window needs at least half the platform's volume on measurable days. Per-chain windows are whole by construction, so the floor is not applied there. Both constants move to package scope, since two files now share them and a second copy would be a second thing to forget. Volume, transactions and share are untouched: a dropped day still counts everywhere it is a measurement rather than a ratio. The methodology now states both gates on the leaderboard spec, which previously described only the zero-fee-day rule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3029 cleared the take-rate bench, and the headline panel and per-chain table on
/compare/fomo-vs-pump-funwent away as expected. The page still showed 63.9%, twice.The survivor is a different board: the Trading terminal leaderboard, whose Take rate / Take rate 7d / Take rate 30d columns read
terminal_window_take_rate_pct, built inwindows.go, which had neither gate.Same defect over three windows. The Solana leg reports nothing and is correctly excluded from the ratio, which is the existing zero-fee-day rule working. Excluding it is right. Using what is left as the platform's take rate is not.
Both gates now apply to the windows too.
Both constants move to package scope. Two files share them now and a second copy would be a second thing to forget.
Volume, transactions and share are untouched: a dropped day still counts everywhere it is a measurement rather than a ratio.
Tests. Two new ones on the window path: the implausible day must not reach
1d,7dor30don either the chain or the all-chains slice while a plausible platform keeps its 1% on all three, and a platform whose fees are believable but cover 0.01% of its volume gets its all-chains rate withheld while keeping the measured rate on the chain that was actually measured. Full suite green,gofmt,go build,go vet, 253 specs valid.Copy. The leaderboard methodology described only the zero-fee-day rule and now states both gates.
Needs the VPS redeploy of
ocb-terminal-activityto take effect.