Repository navigation
the speedtest knew what was wrong and whispered it - #3016
Merged
Merged
Conversation
Reported as "the speedtest is bugged and will not start". It is not bugged. Brave Shields blocks requests to RPC hosts by default, the page detected Brave through navigator.brave.isBrave(), and it said so twice: once before the run and once after, with the exact two-click fix. Both were set in `label-mono text-[10px] text-ink-faint text-center`, the footnote style this site uses for methodology captions. The most actionable sentence on the page was rendered in the least prominent style the design system has, so it read as boilerplate and a reader concluded the tool was broken. An error that carries its own fix but looks like a caption has failed at the only job it had. Both become one shared notice: bordered, amber-tinted, body size, with the consequence as a short lead and the action in its own sentence. Shared so the before-run and after-run messages cannot drift apart. The wording is almost untouched, because it was already right; it was only invisible. The detection logic is left exactly as it is. It earns its keep: the precheck calls eth_chainId on every endpoint and, when all of them fail, fails open and keeps the full list rather than blaming six providers for one local cause. That reasoning is what produced the correct diagnosis here. Gates: tsc clean, eslint clean, 561 tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the speedtest knew what was wrong and whispered it
Reported as "the speedtest is bugged and will not start". It is not bugged.
Brave Shields blocks requests to RPC hosts by default, the page detected
Brave through navigator.brave.isBrave(), and it said so twice: once before
the run and once after, with the exact two-click fix.
Both were set in
label-mono text-[10px] text-ink-faint text-center, thefootnote style this site uses for methodology captions. The most actionable
sentence on the page was rendered in the least prominent style the design
system has, so it read as boilerplate and a reader concluded the tool was
broken. An error that carries its own fix but looks like a caption has
failed at the only job it had.
Both become one shared notice: bordered, amber-tinted, body size, with the
consequence as a short lead and the action in its own sentence. Shared so
the before-run and after-run messages cannot drift apart. The wording is
almost untouched, because it was already right; it was only invisible.
The detection logic is left exactly as it is. It earns its keep: the
precheck calls eth_chainId on every endpoint and, when all of them fail,
fails open and keeps the full list rather than blaming six providers for one
local cause. That reasoning is what produced the correct diagnosis here.
Gates: tsc clean, eslint clean, 561 tests.