Repository navigation
the sitemap listed chains a bench had dropped until the worker caught up - #2973
Merged
Merged
Conversation
The Blast removal deploy was rolled back by the sitemap smoke test: /benchmarks/l2-block-time/blast and /benchmarks/network-fees/blast were still in the sitemap and 308 to their parent. Per-chain sub-pages come from the worker's blob, built from the worker's own checkout, which had not been rebuilt. Benches were already filtered against this build's specs; the chain sub-pages now are too (per_chain_explainer). Locally the sitemap drops exactly those two URLs against production's. Also: l2-block-time measures 9 L2s now, so the title says "and 6 more", and the answer page is back to 9 (it read 8 after the removal).
Flotapponnier
added a commit
that referenced
this pull request
Oct 13, 2026
… up (#2973) (#2974) The Blast removal deploy was rolled back by the sitemap smoke test: /benchmarks/l2-block-time/blast and /benchmarks/network-fees/blast were still in the sitemap and 308 to their parent. Per-chain sub-pages come from the worker's blob, built from the worker's own checkout, which had not been rebuilt. Benches were already filtered against this build's specs; the chain sub-pages now are too (per_chain_explainer). Locally the sitemap drops exactly those two URLs against production's. Also: l2-block-time measures 9 L2s now, so the title says "and 6 more", and the answer page is back to 9 (it read 8 after the removal). (cherry picked from commit 7c3a954)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The prod deploy of #2972 (Blast removal) was rolled back by the sitemap smoke test:
/benchmarks/l2-block-time/blastand/benchmarks/network-fees/blastwere still in the sitemap and 308 to their parent bench.Cause: per-chain sub-pages come from the worker's blob (
perChainSlugs), built from the worker's own checkout, not yet rebuilt. Bench slugs were already filtered against this build's specs; per-chain sub-pages now are too (per_chain_explainer), so the sitemap no longer depends on worker timing for a dropped chain.Local sitemap vs production: drops exactly those 2 URLs, nothing else (99 vs 101 chain sub-pages).
Also fixes the L2 counts: l2-block-time title "and 6 more" (9 L2s), answer page back to 9.
Checks: tsc,
bun test(579 pass),pnpm validate.