Repository navigation
move the official link into the header, where a reader looks for it - #2918
Merged
Merged
Conversation
Asked where the Chainstack link was on /products/chainstack, and whether it had been added at all. It had. It was 11px uppercase in muted grey, right aligned at the far edge of a paragraph halfway down the page, and the honest reading of that question is that the placement failed: 157 links shipped yesterday into a spot where a reader looking for them does not find them. Both headers now carry it directly under the title, at full text size in the foreground colour, with the accent on hover: the product page shows the domain and the X handle, the chain page its website. The product page keeps the description where it was and no longer repeats the links beside it, so there is still one link per destination. No change to what is linked or how: withUtm still tags every outbound href and the stored URL stays clean. tsc --noEmit clean, pnpm validate clean, 492 tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #2917.
The official link on product and chain pages sat at
11pxuppercase in muted grey, right-aligned halfway down the page. It was there; it could not be found. Both headers now carry it directly under the title at full text size in the foreground colour.515 tests pass,
tsc --noEmitclean.