Repository navigation
warm / cold belongs next to the numbers, not in the access row - #2907
Merged
Merged
Conversation
"Private, cold start" shipped as a third ACCESS button beside "Public, no key" and "Private, API key". It reads as a third kind of access, which it is not: it is the same private endpoints, same call, measured on a connection that is never reused. So page.tsx filters keyed-cold out of the access row, and BenchmarkBody renders a Pooled / Cold start toggle in the chart header instead, visible only on the private cohort and sitting next to the numbers it changes. It switches the tier directly, so the URL, the variant cache and the ledger all follow with no new plumbing. Each button carries the distinction in its title: pooled is what a long-running backend gets, cold start is what a serverless invocation gets. The gap between them is a TLS handshake, and until 2026-10-08 this bench measured whichever one happened to apply and ranked providers on that accident. The data model keeps keyed-cold as a tier because that is how a cohort is expressed here; only its placement in the UI changes. tsc --noEmit clean.
Flotapponnier
added a commit
that referenced
this pull request
Oct 8, 2026
#2908) "Private, cold start" shipped as a third ACCESS button beside "Public, no key" and "Private, API key". It reads as a third kind of access, which it is not: it is the same private endpoints, same call, measured on a connection that is never reused. So page.tsx filters keyed-cold out of the access row, and BenchmarkBody renders a Pooled / Cold start toggle in the chart header instead, visible only on the private cohort and sitting next to the numbers it changes. It switches the tier directly, so the URL, the variant cache and the ledger all follow with no new plumbing. Each button carries the distinction in its title: pooled is what a long-running backend gets, cold start is what a serverless invocation gets. The gap between them is a TLS handshake, and until 2026-10-08 this bench measured whichever one happened to apply and ranked providers on that accident. The data model keeps keyed-cold as a tier because that is how a cohort is expressed here; only its placement in the UI changes. tsc --noEmit clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
warm / cold belongs next to the numbers, not in the access row
"Private, cold start" shipped as a third ACCESS button beside "Public, no key"
and "Private, API key". It reads as a third kind of access, which it is not: it
is the same private endpoints, same call, measured on a connection that is
never reused.
So page.tsx filters keyed-cold out of the access row, and BenchmarkBody renders
a Pooled / Cold start toggle in the chart header instead, visible only on the
private cohort and sitting next to the numbers it changes. It switches the tier
directly, so the URL, the variant cache and the ledger all follow with no new
plumbing.
Each button carries the distinction in its title: pooled is what a long-running
backend gets, cold start is what a serverless invocation gets. The gap between
them is a TLS handshake, and until 2026-10-08 this bench measured whichever one
happened to apply and ranked providers on that accident.
The data model keeps keyed-cold as a tier because that is how a cohort is
expressed here; only its placement in the UI changes.
tsc --noEmit clean.