Repository navigation
a cross-chain relayer was being counted as a DEX aggregator - #2824
Closed
Flotapponnier wants to merge 1 commit into
Closed
Flotapponnier wants to merge 1 commit into
Flotapponnier wants to merge 1 commit into
Conversation
The Robinhood explainer read "Four aggregators cover this chain: Mobula, KyberSwap, ParaSwap and Relay." Relay is not an aggregator. It is a cross-chain relayer, and the rest of the site says so: it carries type: relay on bridge-fee and bridge-realized-cost. The same actor had two natures depending on the page. What the probe does is sound and is not changed. All five are asked the same question, a 1 USDC quote on a token that graduated hours ago, and Mobula answers it on /api/2/swap/quoting, a swap quoting endpoint rather than a price one. The spec schema's own taxonomy names Mobula's aggregator side. Nobody is removed from the cohort, because nobody is answering a different question. What was wrong is the naming around the measurement. Every provider now carries a type, so the page states what each one is rather than flattening a relayer into the aggregator cohort, and a methodology line gives the composition outright: four aggregators and one relayer, with the reason the relayer is scored here at all. Found because the page is read as a ranking of DEX aggregators, and OpenChainBench is built by one of the five. A cohort that overclaims what its members are costs more here than it would elsewhere. (cherry picked from commit 9232bfb)
Collaborator
Author
|
Closing: already shipped, by a different route than the others. The relayer-versus-aggregator distinction landed on
The Robinhood paragraph this PR rewrote has since been rewritten again by #3025 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #2823 (merged to
devas9232bfb4), nothing else. Diff againstmainis the same single file, 7 insertions, 1 deletion.The Robinhood explainer, live on production now, reads:
Relay is not an aggregator. It is a cross-chain relayer, and the rest of the site already says so:
type: relayonbridge-feeandbridge-realized-cost. The same actor had two natures depending on the page.Not changed
The probe is sound and nobody leaves the cohort. All five answer the same question (a 1 USDC quote on a token that graduated in the last 24 hours), and Mobula answers it on
/api/2/swap/quoting, a swap quoting endpoint rather than a price one. The schema's own taxonomy names "Mobula's aggregator side" (spec-schema.ts:126). Removing a member whose measurement is valid would be the wrong fix for a naming problem.Changed
type(aggregator×4,relay×1), so the page states what each one isGoing to
maindirectly because the wrong claim is on production now anddevis well ahead of it.Verified
pnpm validate235 specs,pnpm typecheck,pnpm test430 pass / 0 fail.