Repository navigation
two places #2805 missed, one of them on the page - #2806
Merged
Merged
Conversation
The subtitle renders on the bench page and in the share card, and it said OKX and Birdeye are measured on Base and Solana next to a chain list of four. The redeploy that follows this makes it false. The first paragraph of the OKX comment block kept the expired reason too, and called it structural rather than provisional, which is wrong in exactly the way that matters: it was provisional and it expired when BNB joined referenceChains. #2805 rewrote the paragraph below it and left this one, so the block argued with itself. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2805 added BNB to both token-scoped providers but left two statements of the old coverage behind.
The subtitle
It renders on the bench page and in the share card:
That sits next to a chain list of four and becomes false as soon as the redeployed harness emits BNB. Now names the three chains and says plainly that neither provider indexes Robinhood Chain.
The OKX comment block
Its first paragraph kept the expired reason and called it "structural rather than provisional", which is wrong in exactly the way that matters: it was provisional, and it expired when BNB joined referenceChains in #2794. #2805 rewrote the paragraph below it and left this one, so the block argued with itself.
The replacement states the actual constraint (the provider's whole-second clock, not its coverage) and records that the earlier claim was wrong, since the next reader would otherwise have the same reason to leave BNB out.
pnpm validatereports 235 specs valid.No stale "Base and Solana" remains in the spec.
🤖 Generated with Claude Code