Repository navigation
the headline said Binance where the row measures Binance Wallet - #2804
Closed
Flotapponnier wants to merge 1 commit into
Closed
Flotapponnier wants to merge 1 commit into
Flotapponnier wants to merge 1 commit into
Conversation
Two benches rank a row whose provider name is "Binance". What it measures is the self-custody wallet's swap router, one address on BNB, Ethereum and Base, read like any other on-chain trading app in the cohort. On the page that is clear: the provider carries a tag reading "Binance Wallet swap, BNB + Ethereum + Base" beside its name. Every other surface drops the tag and keeps the name alone, and the row currently leads both boards, so the citable API, the share card and any consumer reading the headline got "Binance posts the lowest cost per swap at 172 bps". A reader concludes the exchange is the cheapest venue measured. The measurement says nothing of the kind. Renames the display name on both specs and in the harness's product map. The slug stays "binance" because the product page deliberately covers the exchange's RPC and its wallet together; that is an argument about the slug and never was one about the name. The tag loses the words the name now carries. Found while auditing the bench after a report that its execution cost looked wrong. The cost is not wrong: 165 bps on a wallet router that charges about 50 bps and trades the pairs it trades is unremarkable, and the 1 bp terminal fee on its Base row is already identified in native.go as fee-free Binance Alpha round trips, filtered by DropLoops and documented. The name was the only thing that misread. (cherry picked from commit d8fb936)
Collaborator
Author
|
Holding this on staging for now, at Florent's call. The change is merged to Reopen when we want it on production: the branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #2803 (merged to
devasd8fb936f), nothing else. Diff againstmainis the same 3 files, 15 insertions, 7 deletions.terminal-fill-qualityandterminal-execution-qualityboth rank a provider named Binance. The row measures Binance Wallet's swap router — one address on BNB, Ethereum and Base, read like every other on-chain trading app in the cohort.The page disambiguates with a tag beside the name. No other surface does, and the row leads both boards, so production currently publishes:
through the citable API, the share card, and any consumer reading the headline — on a bench titled "what a swap costs on Axiom, GMGN, FOMO, Photon, Trojan". A reader concludes the exchange is the cheapest venue measured.
Renames the display name on both specs and in the harness product map. The slug stays
binance, because the shared product page is an argument about the slug and never was one about the name.Going to
maindirectly because the wrong name is live on production now anddevis 30+ commits ahead of it.Verified
pnpm validate235 specs,pnpm test430 pass / 0 fail,go buildand harness suite clean.