Skip to content

the headline said Binance where the row measures Binance Wallet #2803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Flotapponnier merged 1 commit into from
Oct 4, 2026
Merged

the headline said Binance where the row measures Binance Wallet #2803

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions benchmarks/terminal-execution-quality.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,10 +305,13 @@ providers:
series: tfq_loss_ex_fee_bps{terminal="banana-gun",chain="all",stat="median",bucket="all"}

# Product slug is "binance" (one product page for the exchange's RPC and
# its wallet); the harness label stays terminal="binance".
# its wallet); the harness label stays terminal="binance". The display
# name must not: the row measures the self-custody wallet's swap router,
# and only the page shows the tag beside it. The headline, the citable
# API and the share card carry the name alone.
- slug: binance
name: Binance
tag: "Binance Wallet swap, BNB + Ethereum + Base"
name: Binance Wallet
tag: "Swap router on BNB, Ethereum and Base"
formula: "Transactions sent to Binance Wallet's swap router (one address on BNB, Ethereum and Base) in a sample of blocks read in full, valued at the pool's state before the swap; loss in bps (gas inside), median over 24 h."
queries:
p50: tfq_loss_ex_fee_bps{terminal="binance",chain="all",stat="median",bucket="all"}
Expand Down
11 changes: 8 additions & 3 deletions benchmarks/terminal-fill-quality.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,10 +360,15 @@ providers:
series: tfq_loss_bps{terminal="banana-gun",chain="all",stat="median",bucket="all"}

# Product slug is "binance" (one product page for the exchange's RPC and
# its wallet); the harness label stays terminal="binance".
# its wallet); the harness label stays terminal="binance". The display
# name must not: the row measures the self-custody wallet's swap router,
# and only the page shows the tag beside it. The headline, the citable
# API and the share card carry the name alone, so "Binance posts the
# lowest cost per swap" read as the exchange on every surface a reader
# meets away from the table.
- slug: binance
name: Binance
tag: "Binance Wallet swap, BNB + Ethereum + Base"
name: Binance Wallet
tag: "Swap router on BNB, Ethereum and Base"
formula: "Transactions sent to Binance Wallet's swap router (one address on BNB, Ethereum and Base) in a sample of blocks read in full, valued at the pool's state before the swap; loss in bps (gas inside), median over 24 h."
queries:
p50: tfq_loss_bps{terminal="binance",chain="all",stat="median",bucket="all"}
Expand Down
2 changes: 1 addition & 1 deletion harnesses/terminal-fill-quality/cmd/script/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1441,7 +1441,7 @@ func productOf(slug string) (string, string) {
return slug, "solana"
}

var productNames = map[string]string{"fomo": "FOMO", "gmgn": "GMGN", "axiom": "Axiom", "banana-gun": "Banana Gun", "binance": "Binance", "basedbot": "BasedBot", "pump-fun": "pump.fun app", "phantom": "Phantom", "maestro": "Maestro", "bloom": "Bloom"}
var productNames = map[string]string{"fomo": "FOMO", "gmgn": "GMGN", "axiom": "Axiom", "banana-gun": "Banana Gun", "binance": "Binance Wallet", "basedbot": "BasedBot", "pump-fun": "pump.fun app", "phantom": "Phantom", "maestro": "Maestro", "bloom": "Bloom"}

// productAlias: the product a row belongs to when the bench names it
// differently from the row prefix (Binance Wallet's rows are the Binance
Expand Down
Loading