Repository navigation
MoleculeNet Classification Data : Modularization, dynamic splits, Clean Code - #174
aditya0by0 wants to merge 86 commits into
Conversation
|
@sfluegel05, once I complete the gnn experiments with molecule net dataset, then we could merge the PR. Until then we could keep this PR in the draft state. |
* Rename 'val' to 'validation' in data splits * Update chebi-utils version requirement in pyproject.toml
…hEB-AI/python-chebai into fix/molecule_net_dynamic_split
|
One change introduced in this PR that is worth pointing out: The model checkpoint callbacks changed from saving every 25 epochs and the top 3 models (micro-f1) to only saving the top model (macro-f1). Since we typically optimize for macro-f1, this makes sense, but should get documented for the next release |
|
I implemented some minor (mostly cosmetic) changes. The only behaviour-changing commits are b05d32a where I extended the BCE loss for other reductions than mean and d97d230 where I retrieve the splits instead of raising an error (otherwise, a user would have to first build the dataset, then run the learn command with the right file path. now, they can run learn directly as usual). |
…hEB-AI/python-chebai into fix/molecule_net_dynamic_split
|
Unit test failure reason: The Install dependencies step failed before tests ran. On Python 3.12, pip could not install the pinned dependency: “ERROR: No matching distribution found for deepchem==2.8.0”, causing exit code 1. This is a dependency/Python-version compatibility issue, not flaky infrastructure. Likely fix: use a Python version supported by deepchem==2.8.0 or update the DeepChem requirement. @sfluegel05, Could you please provide a suggestion regarding this. |
|
yeah, deepchem is a bit behind regarding releases. I am working with the latest pre-release which supports Python 3.12 https://pypi.org/project/deepchem/2.8.1.dev20260821122258/. Based on the w&b logs, you used Python 3.10 and deepchem 2.8.0 in your experiments. So I would suggest pinning deepchem to >= 2.8.0 (with a comment that it only supports Python <3.12) and mention in the paper that we ran the experiments with Python 3.10 and deepchem 2.8. |
Changes related to Molecule Net classification introduced in #130
General Changes
Check before dataloader to assert if the data is empty (as pytorch or lightning doesn't check this)
Generalize _DynamicDataset class to all datasets by replacing
_graph_to_raw_datasetto_preprocess_data_into_dataframeModularize splitting logic into separate classes (so we dont need to specifiy the split logic for every new data class, rather just inherent the required splitting logic class )
Suggested Metric as per data type by https://arxiv.org/abs/1703.00564 for Molecule Net dataset