Repository navigation
Conversation
31c40c9 to
a94543e
Compare
d15321f to
8acdbdf
Compare
|
Thanks for this. I've made some changes on top of your branch. Now there's only one API and no duplicated detection code:
I tested on Linux but couldn't compile the Windows changes. Needs build and test on Windows, ideally on a hybrid Intel machine. |
|
Thanks! (1) Confirmed that the Windows MSVC x64 build succeeds. Simulated topology tests and native detection on my homogeneous CPU also passed. I haven’t tested on a real Intel hybrid machine. (2) The purpose of getCPUAffinityCapability() was to distinguish enforceable CPU restrictions from advisory placement hints, such as macOS affinity tags, and unsupported affinity. It was separate from getAvailableCPUs() because knowing which CPUs are available does not itself establish whether placement can be enforced. My work on the FAH client currently uses it as a gate for managed allocation: bool newHard = if (newAvailable.empty()) newHard = false; Actual affinity enforcement happens separately in the client’s process launcher. Removing the capability API is fine. I can determine support in the client using a Windows/Linux platform check and a nonempty available-CPU set, while retaining exact-mask verification at launch. |
|
Apple Clang reported an ambiguous conversion in |
|
Thanks for testing the Windows build. You don't need a platform check in the client. Testing on a real hybrid Intel machine, on Linux or Windows, is still open if anyone has one. |
Builds on ac74f1d ("Better performance CPU detection. CPU affinity for subprocesses")
Extending that support into the more general CPU topology interface needed for the affinity/resource-group work I plan to add to the FAH client.