Repository navigation
STL writer: copy at most the hash into the 80-byte header - #460
Open
dylanoliverdo-coder wants to merge 1 commit into
Open
dylanoliverdo-coder wants to merge 1 commit into
dylanoliverdo-coder wants to merge 1 commit into
Conversation
The header copied 80 bytes from the hash string, which is shorter than 80 bytes, so it read past the end of the string. Two runs of the same job wrote the same triangles but different header bytes, and so different files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Writer::writeHeadercopied 80 bytes from the hash string withmemcpy(header, hash.c_str(), 80). The hash is shorter than 80 bytes, so this read past the end of the string. Two runs of the same job wrote identical triangles but different header bytes, so the files differed.Fix: copy
min(hash.size(), 80)bytes into the zero-filled header (adds#include <algorithm>). The hash itself stays in the header.Check: the same job, cut twice, gives byte-identical files with this change. On master the whole-file hash changes from run to run while the triangle bytes (from byte 80 on) match.
Tests: the
tests/testHarnessgcodetool suites pass 15 of 15 on master and on this branch.🤖 Generated with Claude Code