Repository navigation
feat(store): show the sort order when tab changes it - #8
Open
albertonoys wants to merge 2 commits into
Open
albertonoys wants to merge 2 commits into
albertonoys wants to merge 2 commits into
Conversation
- tab cycled the sort order with nothing on screen saying so; it now shows "Sort: <order>" in the status line - sort_rule_label(), unused until now, returns readable names
- the catalog shows one app at a time, so keeping the selected app made tab look like it did nothing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Tab on the catalog screen cycles the sort order (Default, Newest first, Oldest first, A-Z, Z-A), but nothing on screen says so:
sort_rule_label()exists but nothing calls it.Change
Sort: <order>in the status line, usingsort_rule_label(), which now returns readable names ("Newest first" instead of "new").Tests
test_catalog_controller: Tab sets the status message and selects the first app. The old code fails the second check.test_appstore_input_controllerandtest_appstore_request_coordinatorlink the catalog controller and stub the client functions it calls, so both got asort_rule_labelstub.run_tests.sh, which needs Linux.