Conversation
| CameraPreviewShape::Round => { | ||
| config.camera.shape = CameraShape::Square; | ||
| config.camera.rounding = 100.0; | ||
| config.camera.rounding_type = cap_project::CornerStyle::Rounded; |
Contributor
There was a problem hiding this comment.
Round preview breaks existing test
When the existing camera-state test checks the Round shape, this line changes rounding_type to Rounded, but the test still expects its default Squircle value. Its full-config assertion therefore fails, breaking the desktop test suite. Update the expected config to include the intended corner-style change.
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/desktop/src-tauri/src/recording.rs
Line: 6703
Comment:
**Round preview breaks existing test**
When the existing camera-state test checks the Round shape, this line changes `rounding_type` to `Rounded`, but the test still expects its default `Squircle` value. Its full-config assertion therefore fails, breaking the desktop test suite. Update the expected config to include the intended corner-style change.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes circular/round camera shape not applying properly on Linux during recording preview.
In
apply_recording_camera_preview_state(apps/desktop/src-tauri/src/recording.rs), whenCameraPreviewShape::Roundwas selected,config.camera.rounding_typewas not set toCornerStyle::Rounded, causing the camera bubble to render with incorrect corners.Tested on Linux (CachyOS / Wayland).
The PR is not ready to merge because the round-preview case breaks an existing desktop test.
Findings
Fix with agent prompt
Summary
The PR makes round camera previews use the
Roundedcorner style in generated recording configurations.Reviews (1) · Last reviewed commit: "fix(camera): set camera rounding_type to..."