Skip to content

Show imgui in the rasterizer path #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
raydelto wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Show imgui in the rasterizer path #4

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bfcdf00
Show imgui in the rasterizer path
raydelto May 25, 2026
5d9ede8
Revert "Show imgui in the rasterizer path"
raydelto May 25, 2026
e7aaa6c
Show imgui in the rasterizer path
raydelto May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 61 additions & 3 deletions src/renderer/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,7 @@ impl VulkanRenderer {
} else {
// ── Rasterizer path ────────────────────────────────────────────────
self.update_uniform_buffer(frame, scene)?;
self.record_command_buffer(cb, image_index as usize, frame)?;
self.record_command_buffer(cb, image_index as usize, frame, imgui_draw_data)?;
}

let wait_semaphores = [acquire_sem];
Expand Down Expand Up @@ -859,10 +859,11 @@ impl VulkanRenderer {
}

fn record_command_buffer(
&self,
&mut self,
cb: vk::CommandBuffer,
image_index: usize,
frame: usize,
draw_data: Option<*const imgui::DrawData>,
) -> Result<(), Box<dyn std::error::Error>> {
let begin_info = vk::CommandBufferBeginInfo { ..Default::default() };
unsafe { self.device.device.begin_command_buffer(cb, &begin_info)? };
Expand Down Expand Up @@ -899,9 +900,66 @@ impl VulkanRenderer {
);
self.device.device.cmd_draw_indexed(cb, self.index_count, 1, 0, 0, 0);
self.device.device.cmd_end_render_pass(cb);
self.device.device.end_command_buffer(cb)?;
}

// ── ImGui overlay ───────────────────────────────────────────────────────
// The main render pass left the swapchain image in PRESENT_SRC_KHR.
// Transition to COLOR_ATTACHMENT_OPTIMAL for the ImGui render pass.
if let (Some(dd_ptr), Some(ref mut layer)) =
(draw_data, self.imgui_layer.as_mut())
{
let dd = unsafe { &*dd_ptr };
let swapchain_image = self.swapchain.images[image_index];
let extent = self.swapchain.extent;

let barrier = vk::ImageMemoryBarrier {
old_layout: vk::ImageLayout::PRESENT_SRC_KHR,
new_layout: vk::ImageLayout::COLOR_ATTACHMENT_OPTIMAL,
src_access_mask: vk::AccessFlags::COLOR_ATTACHMENT_WRITE,
dst_access_mask: vk::AccessFlags::COLOR_ATTACHMENT_READ
| vk::AccessFlags::COLOR_ATTACHMENT_WRITE,
src_queue_family_index: vk::QUEUE_FAMILY_IGNORED,
dst_queue_family_index: vk::QUEUE_FAMILY_IGNORED,
image: swapchain_image,
subresource_range: full_color_range(),
..Default::default()
};
unsafe {
self.device.device.cmd_pipeline_barrier(
cb,
vk::PipelineStageFlags::COLOR_ATTACHMENT_OUTPUT,
vk::PipelineStageFlags::COLOR_ATTACHMENT_OUTPUT,
vk::DependencyFlags::empty(),
&[], &[], &[barrier],
);
}

let rp_begin = vk::RenderPassBeginInfo {
render_pass: layer.render_pass,
framebuffer: layer.framebuffers[image_index],
render_area: vk::Rect2D {
offset: vk::Offset2D { x: 0, y: 0 },
extent,
},
clear_value_count: 0,
p_clear_values: std::ptr::null(),
..Default::default()
};
unsafe {
self.device.device.cmd_begin_render_pass(
cb,
&rp_begin,
vk::SubpassContents::INLINE,
);
}
layer.renderer.cmd_draw(cb, dd)
.map_err(|e| format!("imgui cmd_draw: {}", e))?;
unsafe {
self.device.device.cmd_end_render_pass(cb);
}
}

unsafe { self.device.device.end_command_buffer(cb)?; }
Ok(())
}

Expand Down