Repository navigation
Conversation
…rker runs it execute_async hands the calls to a worker thread, and execute() then read exe_queue and known_contracts (get_transaction, get_deploy_transaction, the payable convention) without public_access_lock while the main thread could change them, and wrote the plain bool executor_ready from both threads. Resolve the starter transaction, the deploy transaction and the method name convention in execute_async, which runs under the lock, and let execute() use them; its synchronous callers already hold the lock and keep resolving them there. executor_ready becomes atomic. The values are the ones execute() looked up before, so results are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this PR
SmartContracts::execute_asynchands contract calls to a worker thread, andexecute()then readexe_queueandknown_contracts(get_transaction,get_deploy_transaction, the payable naming convention) withoutpublic_access_lock, while the main thread could change them; the plainbool executor_readywas written from both threads. These are data races that can crash the node or execute a call with wrong inputs.What changes
solver/src/smartcontracts.cpp,solver/include/solver/smartcontracts.hpp: the starter transaction, the deploy transaction and the method-name convention are resolved inexecute_async, which runs under the lock, and passed toexecute(); its synchronous callers already hold the lock and keep resolving them there.executor_readyis atomic. The values are the onesexecute()looked up before, so results are unchanged.Effect on the network
None: same inputs, same results, without the races.
Tests
Built and run on 4a95aaa (GCC 13); covered in the fork by private-network runs with a contract load.
Same change in the community fork: CreditsCommunity#31, running on mainnet community nodes.