Skip to content

api: replace the executor client on any transport error - #91

Open
EnzinoBB wants to merge 1 commit into
CREDITSCOM:masterfrom
CreditsCommunity:official/executor-client-reset
Open

EnzinoBB wants to merge 1 commit into
CREDITSCOM:masterfrom
CreditsCommunity:official/executor-client-reset

Conversation

@EnzinoBB

@EnzinoBB EnzinoBB commented Nov 1, 2026

Copy link
Copy Markdown

Why this PR

The Thrift concurrent client marks itself unusable for good on any receive error, but the node replaced it only on NOT_OPEN, that is when the next call had already failed. One timeout or dropped connection to the contract executor therefore failed the following contract call too, on this node only, and a late reply to a timed-out call could still arrive on the old connection.

What changes

api/src/executor.cpp: the client is replaced on every TTransportException; the watcher reconnects as before.

Effect on the network

None on the wire. A node no longer fails the contract call that follows a transport error, so it no longer votes differently from the other confidants for that call.

Tests

Built and run on 4a95aaa (GCC 13). In the fork, private networks with smart contracts and the mainnet executor run with this change, including executor restarts.

Same change in the community fork: CreditsCommunity#29, running on mainnet community nodes.

The Thrift concurrent client marks itself bad (stop_ set for good) on any
receive error, but the node replaced it only on NOT_OPEN, that is when the
next call had already failed. One timeout or dropped connection therefore
failed the following contract call too, on this node only, and a late reply
to a timed-out call could still arrive on the old connection. Replace the
client on every TTransportException; the watcher reconnects as before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant