Repository navigation
Conversation
The Thrift concurrent client marks itself bad (stop_ set for good) on any receive error, but the node replaced it only on NOT_OPEN, that is when the next call had already failed. One timeout or dropped connection therefore failed the following contract call too, on this node only, and a late reply to a timed-out call could still arrive on the old connection. Replace the client on every TTransportException; the watcher reconnects as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this PR
The Thrift concurrent client marks itself unusable for good on any receive error, but the node replaced it only on
NOT_OPEN, that is when the next call had already failed. One timeout or dropped connection to the contract executor therefore failed the following contract call too, on this node only, and a late reply to a timed-out call could still arrive on the old connection.What changes
api/src/executor.cpp: the client is replaced on everyTTransportException; the watcher reconnects as before.Effect on the network
None on the wire. A node no longer fails the contract call that follows a transport error, so it no longer votes differently from the other confidants for that call.
Tests
Built and run on 4a95aaa (GCC 13). In the fork, private networks with smart contracts and the mainnet executor run with this change, including executor restarts.
Same change in the community fork: CreditsCommunity#29, running on mainnet community nodes.