Skip to content

Fix/portfolio review nitpicks - #1

Merged
CJud25 merged 2 commits into
mainfrom
fix/portfolio-review-nitpicks
Jul 5, 2026
Merged

CJud25 merged 2 commits into
mainfrom
fix/portfolio-review-nitpicks

Conversation

@CJud25

@CJud25 CJud25 commented Jul 5, 2026

Copy link
Copy Markdown
Owner

No description provided.

CJud25 and others added 2 commits July 5, 2026 08:19
- O1: average_cycle_time computed over CLOSED rows only (14.8->4.23d) so it
  matches its "Closed-request duration" label; same fix on the
  "Avg Cycle Time by Request Type" chart.
- O2/O3: guard empty-input paths in foster_matching and
  triage_adoption_inquiries (return well-formed empty frames, not KeyError);
  add smoke.py regression checks.
- O4: reword the cross-domain "score means the same thing" over-claim in
  README, DEMO_SCRIPT, scoring.py, CONTRACTS.md (net hours saved is the shared
  anchor; the impact term is domain-specific by design).
- Fable follow-ups: fix a sibling foster_matching crash on zero eligible
  volunteers (astype(bool) on the capacity mask); route unmatched-dog
  inquiries to "Missing Information" instead of a false "Strong Match".

All three harness suites (smoke/ranker/automation) pass.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017NpGUcyjp3phfhYRWycKur
- README ranker alt-text + in-app "Scoring Formula" caption reworded to match the
  O4 anchor-vs-impact framing (net hours saved is the shared anchor; impact term
  domain-specific).
- CONTRACTS.md documents that average_cycle_time is closed-requests-only (O1).
- requirements.txt: drop the stale commented openai/anthropic "AI polish" extras
  (no such path remains in the shipped app).
- CHANGES.md: add a short portfolio-review-pass note.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017NpGUcyjp3phfhYRWycKur
@CJud25
CJud25 merged commit e6c7615 into main Jul 5, 2026
2 checks passed
@CJud25
CJud25 deleted the fix/portfolio-review-nitpicks branch July 5, 2026 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant