Repository navigation
Fix/portfolio review nitpicks - #1
Merged
Merged
Conversation
- O1: average_cycle_time computed over CLOSED rows only (14.8->4.23d) so it matches its "Closed-request duration" label; same fix on the "Avg Cycle Time by Request Type" chart. - O2/O3: guard empty-input paths in foster_matching and triage_adoption_inquiries (return well-formed empty frames, not KeyError); add smoke.py regression checks. - O4: reword the cross-domain "score means the same thing" over-claim in README, DEMO_SCRIPT, scoring.py, CONTRACTS.md (net hours saved is the shared anchor; the impact term is domain-specific by design). - Fable follow-ups: fix a sibling foster_matching crash on zero eligible volunteers (astype(bool) on the capacity mask); route unmatched-dog inquiries to "Missing Information" instead of a false "Strong Match". All three harness suites (smoke/ranker/automation) pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017NpGUcyjp3phfhYRWycKur
- README ranker alt-text + in-app "Scoring Formula" caption reworded to match the O4 anchor-vs-impact framing (net hours saved is the shared anchor; impact term domain-specific). - CONTRACTS.md documents that average_cycle_time is closed-requests-only (O1). - requirements.txt: drop the stale commented openai/anthropic "AI polish" extras (no such path remains in the shipped app). - CHANGES.md: add a short portfolio-review-pass note. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017NpGUcyjp3phfhYRWycKur
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.