Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1
install.shandinstall.ps1unconditionally regeneratedconfig.tomlwith default template values on every install and update, wiping configured[features], resetting the chosenmodel, and revertingmodel_provider = "byok-local"or subscription back tobyteask.This guards
config.tomlgeneration so default settings are only written whenconfig.tomldoes not already exist, preserving existing user configuration on updates while safely insertingmodel_catalog_jsonif upgrading from an older release lacking it.Tested:
tests/test_install.sh(fails before, passes after)tests/test_install.sh,sh -n install.sh,sh -n byteask