Skip to content

Fix config.toml overwritten on update - #2

Open
h30s wants to merge 1 commit into
ByteAsk:mainfrom
h30s:fix/preserve-config-on-update
Open

h30s wants to merge 1 commit into
ByteAsk:mainfrom
h30s:fix/preserve-config-on-update

Conversation

@h30s

@h30s h30s commented Oct 4, 2026

Copy link
Copy Markdown

Fixes #1

install.sh and install.ps1 unconditionally regenerated config.toml with default template values on every install and update, wiping configured [features], resetting the chosen model, and reverting model_provider = "byok-local" or subscription back to byteask.

This guards config.toml generation so default settings are only written when config.toml does not already exist, preserving existing user configuration on updates while safely inserting model_catalog_json if upgrading from an older release lacking it.

Tested:

  • added regression test tests/test_install.sh (fails before, passes after)
  • ran tests/test_install.sh, sh -n install.sh, sh -n byteask
  • ran the reproduction script from the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

install.sh: config.toml overwritten on update, dropping features, custom model, and BYOK

1 participant