Repository navigation
Fix Chromium158 branding path validation on Windows - #112
Draft
tysonthomas9 wants to merge 1 commit into
Draft
tysonthomas9 wants to merge 1 commit into
tysonthomas9 wants to merge 1 commit into
Conversation
Collaborator
Author
|
Claude CLI review completed with tools disabled: no blocking findings. Six helper tests passed, covering valid Windows/POSIX paths and rejection of traversal, theme siblings, rooted/drive-relative/UNC paths. Existing filesystem containment and content hashes are preserved. Windows candidate CI is pinned to991ac1eae70dab38d6b06943d50320d7c131986f and will run the same tests on the Windows worker before applying patches. Retry is tracked in BrowserOperator/test-github-pipeline#9. The local Mac integration checkout was restored to6926ab27 and no frozen Mac artifact/input changed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chromium158 Windows CI reaches the reviewed branding check, then rejects every normal theme destination:
str(WindowsPath(...))uses backslashes, but the helper compares it with the forward-slash prefixchrome/app/theme/.Use
as_posix()for that exact theme-subtree check while retaining native path parsing, traversal rejection, filesystem containment and asset hashes. Reject anchored source/destination paths as well, including Windows root-relative, drive-relative and UNC paths. The patch series, branding files and frontend UI code are unchanged.Validation: all6 helper unittest tests pass, including valid
PureWindowsPath/PurePosixPathassets, subtree siblings, traversal, absolute, drive-relative and UNC cases. Claude CLI review found no blocking issues. The actual Windows retry is tracked in BrowserOperator/test-github-pipeline#9.Stacked on #111. This fix is for the Windows candidate; the frozen Mac release inputs remain pinned to6926ab27d98bc2d158e02a0ca47e0708d040a16b. No release is published by this PR.