Repository navigation
Capture the exact native branding inputs used by Chromium 158 releases - #110
Draft
tysonthomas9 wants to merge 1 commit into
Draft
tysonthomas9 wants to merge 1 commit into
tysonthomas9 wants to merge 1 commit into
Conversation
Collaborator
Author
|
Claude reviewed the integrated release changes and followed up on the fixes. The complete reviews, responses and current validation are recorded in #111 (comment) . Follow-up fixes live in the main integration PR111 rather than rewriting the component stack. Publishing remains held until the owner merges PR111. Both Chromium158 architecture builds now pass with the final banner rendering fix; signing/notarization and final DMG checks await Keychain unlock. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release audit found 36 native branding text files whose live contents were not fully reproduced by the original feature patch series. Capture that existing residual output as patch 10, and pin 74 matching theme inputs to BrowserOperator/build-script at c236edd3378906aa9239126707c26597b607698b using source/destination SHA256 metadata. This does not change the already-used branding behavior or add duplicate binary assets. Generated license credits, unused recovery files and node_modules are excluded.
The patch helper now validates overlapping patches in a private partial source tree, prepares one checked delta before touching the real checkout, and verifies the pinned asset source before copying. Standard unified-diff blank context is exempted from whitespace lint only for stored patch files; product code checks remain unchanged.
Validation: all ten patches applied to fresh 158 source files and all 74 assets matched the live release inputs exactly. Ordered-overlap and late-failure tests passed, proving the real source stays unchanged if a later patch fails. The inherited AI baseline was already covered by merged PR76. docs/chromium-158-release-pr-audit.md records coverage and the remaining main-integration/publishing gate.
Stacked on #109. Owner requires NO public/private release updates or Omaha promotion until merge. macOS product0.7.0 / Chromium158 rebuilds and qualification are in progress.