Skip to content

Capture the exact native branding inputs used by Chromium 158 releases - #110

Draft
tysonthomas9 wants to merge 1 commit into
codex/native-ai-update-bannerfrom
codex/chromium158-branding-coverage
Draft

tysonthomas9 wants to merge 1 commit into
codex/native-ai-update-bannerfrom
codex/chromium158-branding-coverage

Conversation

@tysonthomas9

Copy link
Copy Markdown
Collaborator

The release audit found 36 native branding text files whose live contents were not fully reproduced by the original feature patch series. Capture that existing residual output as patch 10, and pin 74 matching theme inputs to BrowserOperator/build-script at c236edd3378906aa9239126707c26597b607698b using source/destination SHA256 metadata. This does not change the already-used branding behavior or add duplicate binary assets. Generated license credits, unused recovery files and node_modules are excluded.

The patch helper now validates overlapping patches in a private partial source tree, prepares one checked delta before touching the real checkout, and verifies the pinned asset source before copying. Standard unified-diff blank context is exempted from whitespace lint only for stored patch files; product code checks remain unchanged.

Validation: all ten patches applied to fresh 158 source files and all 74 assets matched the live release inputs exactly. Ordered-overlap and late-failure tests passed, proving the real source stays unchanged if a later patch fails. The inherited AI baseline was already covered by merged PR76. docs/chromium-158-release-pr-audit.md records coverage and the remaining main-integration/publishing gate.

Stacked on #109. Owner requires NO public/private release updates or Omaha promotion until merge. macOS product0.7.0 / Chromium158 rebuilds and qualification are in progress.

@tysonthomas9

Copy link
Copy Markdown
Collaborator Author

Claude reviewed the integrated release changes and followed up on the fixes. The complete reviews, responses and current validation are recorded in #111 (comment) . Follow-up fixes live in the main integration PR111 rather than rewriting the component stack. Publishing remains held until the owner merges PR111. Both Chromium158 architecture builds now pass with the final banner rendering fix; signing/notarization and final DMG checks await Keychain unlock.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant