Repository navigation
Conversation
Owner
|
Now that I have a CI environment working, will need to fix the tests before merging this, but shouldn't be too much trouble. Will definitely want to merge this in for the next release. My apologies for the delay in getting to this! I believe I used the framerate to ensure that a statsfile applied to the correct video, so I'll have to remove that check/requirement. I believe most of the test cases are still valid, just need to be updated accordingly. I can take over the PR from here, many thanks! |
Owner
|
Unfortunately this needs to be redone due to refactoring of the changed files, but it shouldn't take too long. Will re-apply these changes in the v0.5.5 release (issue updated accordingly). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #136 , this removes cut list and frame rate from top of CSV files. Pretty sure this breaks some of the test code that looks for those things (at least the frame rate), and not really sure whether to rip out the tests or rewrite them.