You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
save_images API function does not work correctly with some characters #450
Can you provide a sample stack trace of what error you get? It would be good to know if this is coming from OpenCV or something PySceneDetect is doing with the paths.
I have tested the PySenceDetect function locally and it can print the path normally. The problem may occur with cv2.iwrite. There is no error output when calling save_images.
I suspected so, I audited the code paths, and PySceneDetect tries to be good about respecting UTF-8 characters in paths. We can probably work around this issue by writing to an in-memory buffer and then saving that to disk separate.
changed the title [-]scenedetect.scene_manager.save_images cannot save images properly[/-][+]`save_images` API function does not work correctly with some characters[/+]on Oct 31, 2024
I should have a fix for this in the next version. During the process I was also able to make it multithreaded so now the save-images command should run close to 40% faster in some cases.
Activity
Breakthrough commentedon Oct 27, 2024
Can you provide a sample stack trace of what error you get? It would be good to know if this is coming from OpenCV or something PySceneDetect is doing with the paths.
pengyouak commentedon Oct 27, 2024
I have tested the PySenceDetect function locally and it can print the path normally. The problem may occur with cv2.iwrite. There is no error output when calling save_images.
cv2.imwrite(get_and_create_path(file_path, output_dir), frame_im, imwrite_param)
Breakthrough commentedon Oct 30, 2024
I suspected so, I audited the code paths, and PySceneDetect tries to be good about respecting UTF-8 characters in paths. We can probably work around this issue by writing to an in-memory buffer and then saving that to disk separate.
[-]scenedetect.scene_manager.save_images cannot save images properly[/-][+]`save_images` API function does not work correctly with some characters[/+][save-images] Add multithreaded version of save-images
Breakthrough commentedon Nov 10, 2024
I should have a fix for this in the next version. During the process I was also able to make it multithreaded so now the
save-imagescommand should run close to 40% faster in some cases.[save-images] Add multithreaded version of save-images
pengyouak commentedon Nov 10, 2024
非常感谢你能修复这个问题，这能让我减少很多不必要的麻烦~
[save-images] Add multithreaded version of save-images
[scene_manager] Fix save_images not working with UTF-8 paths #450
[scene_manager] Fix save_images not working with UTF-8 paths #450
[scene_manager] Fix save_images not working with UTF-8 paths #450
[scene_manager] Fix save_images not working with UTF-8 paths #450 (#460)
[save-images] Add multithreaded version of save-images
[save-images] Add multithreaded version of save-images (#456)