Skip to content

Incorrect warning in detect_scenes when end_time is not a FrameTimecode #346

Closed

Description

@Breakthrough

Description:

As @Vsevosemnog pointed out in #345, a runtime warning is emitted when passing strings for end_time to SceneManager.detect_scenes:

[2023-08-10 09:00:49,774] INFO - '<' not supported between instances of 'str' and 'int'

This is caused by the comparison on this line. The timecode is converted after the comparison below.

The code should still function even with the incorrect comparison, but we should avoid doing this check if the input is a string.

Activity

  1. added this to the v0.6.3 milestone on Aug 10, 2023
  2. added a commit that references this issue on Jan 29, 2024
    29d497d
  3. added a commit that references this issue on Apr 18, 2024
    e668b67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions