Repository navigation
Conversation
t91a60
marked this pull request as ready for review
October 17, 2026 21:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding an external-link row and leaving it blank can persist
{ "match": "", "isRegex": false }on blur. Sincehref.includes('')is true for every URL, this makes ordinary Steam links open externally. Empty regexes have the same effect.Ignore empty and whitespace-only rules when matching. Existing saved lists do not need to be reset; nonblank patterns are unchanged, including explicit match-all regexes.
Eight regression tests pass, covering blank text/regex rules, mixed lists, explicit match-all patterns, and current-tab behavior. An isolated Chromium fixture reproduces both empty-rule failures before the fix and passes all four browser cases afterward, with no console errors. The location destination is captured rather than sent to Steam.
bun run build,bun run lint,bun run check, test TypeScript checking, formatting checks, andgit diff --checkpass in an LF checkout. The build retains the existing circular-dependency warning. Steam/Millennium integration remains untested.Related: #33, #35, #118. Those reports describe the same symptom, but do not establish that blank rules caused their individual cases.