Repository navigation
Conversation
t91a60
marked this pull request as ready for review
October 17, 2026 21:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extension state events were grouped by type, so a
LOADED,UNLOADED,LOADEDsequence replayed asLOADED,LOADED,UNLOADED. Reading and clearing the queue in separate CDP calls could also discard events arriving between those calls.Use a FIFO queue and drain it in one evaluation. Await listeners before dispatching the next event so an asynchronous install cannot finish after a later removal. Catch rejected listeners without stopping the remaining callbacks or events.
Verification:
bun run build,bun run lint,bun run check, test TypeScript checking, formatting checks, andgit diff --checkpass in an LF checkout. The build retains the existing circular-dependency warning.Tests execute the injected functions in a VM and simulate the JSON/CDP boundary. Native Chrome event delivery and Steam/Millennium integration have not been tested. This does not address initial inventory hydration or general plugin teardown.