This repository was archived by the owner on Mar 20, 2023. It is now read-only.
Repository navigation
Fix NVHPC 21.9 compilation of some models. - #679
Merged
Merged
Conversation
olupton
force-pushed
the
olupton/nvhpc-21.9-compat
branch
from
October 25, 2021 13:58
0b24210 to
d1ded91
Compare
Codecov Report
@@ Coverage Diff @@
## master #679 +/- ##
=======================================
Coverage 55.25% 55.25%
=======================================
Files 107 107
Lines 8718 8718
=======================================
Hits 4817 4817
Misses 3901 3901 Continue to review full report at Codecov.
|
Collaborator
|
Logfiles from GitLab pipeline #21511 (:no_entry:) have been uploaded here! Status and direct links:
|
Contributor
Author
|
Retest this please Jenkins. |
Collaborator
|
Logfiles from GitLab pipeline #21552 (:no_entry:) have been uploaded here! Status and direct links:
|
olupton
force-pushed
the
olupton/nvhpc-21.9-compat
branch
from
October 26, 2021 08:26
d1ded91 to
25061a9
Compare
Collaborator
|
Logfiles from GitLab pipeline #21662 (:no_entry:) have been uploaded here! Status and direct links:
|
8 tasks done
Collaborator
|
Logfiles from GitLab pipeline #21743 (:white_check_mark:) have been uploaded here! Status and direct links:
|
olupton
marked this pull request as ready for review
October 26, 2021 16:43
olupton
force-pushed
the
olupton/nvhpc-21.9-compat
branch
from
October 27, 2021 09:38
5ce5e2c to
5741875
Compare
Collaborator
|
Logfiles from GitLab pipeline #21853 (:white_check_mark:) have been uploaded here! Status and direct links:
|
pramodk
approved these changes
Oct 27, 2021
pramodk
left a comment
pramodk
left a comment
Collaborator
There was a problem hiding this comment.
LGTM once submodules are updated
olupton
force-pushed
the
olupton/nvhpc-21.9-compat
branch
from
October 27, 2021 15:23
5741875 to
dc508db
Compare
* Update mod2c submodule with mod2c#73, which does the same thing there. * Update nmodl submodule with nmodl#762, which fixes code generation for the SH_na8st.mod mechanism in the reduced_dentate model.
olupton
force-pushed
the
olupton/nvhpc-21.9-compat
branch
from
October 27, 2021 15:26
dc508db to
03a0056
Compare
Collaborator
|
Logfiles from GitLab pipeline #21948 (:white_check_mark:) have been uploaded here! Status and direct links:
|
5 tasks done
pramodk
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Nov 2, 2022
This fixes compilation with NVHPC 21.9 in some cases. * Update mod2c submodule with mod2cBlueBrain/CoreNeuron#73, which does the same thing there. * Update nmodl submodule with nmodlBlueBrain/CoreNeuron#762, which fixes code generation for the SH_na8st.mod mechanism in the reduced_dentate model. CoreNEURON Repo SHA: BlueBrain/CoreNeuron@d2f4d3d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See the description of neuronsimulator/nrn#1515, which summarises the many issues and PRs...
Use certain branches for the SimulationStack CI
CI_BRANCHES:NEURON_BRANCH=olupton/reduced-dentate,