This repository was archived by the owner on Mar 20, 2023. It is now read-only.
Repository navigation
Pass PI value from NEURON to CoreNEURON - #494
Merged
Merged
Conversation
- Created new pi global parameter which is read by NEURON globals.dat or directly NEURON in online mode - Use this pi in lfp calculation and test - Removed a deprecated boost test header file
Merged
pramodk
reviewed
Feb 10, 2021
cattabiani
reviewed
Feb 11, 2021
pramodk
approved these changes
Feb 11, 2021
Collaborator
|
@bdelmarm : feel free to merge this PR (it will be merged in your PR). |
bdelmarm
approved these changes
Feb 12, 2021
bdelmarm
left a comment
bdelmarm
left a comment
Contributor
There was a problem hiding this comment.
Great @iomaganaris . Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the
lfpPR during the calculation oflfpthere is a variablePIused. The value of this variable should be same asNEURONand the variable used by the mod files.globals.dator directly NEURON in online mode