Skip to content
This repository was archived by the owner on Mar 20, 2023. It is now read-only.
This repository was archived by the owner on Mar 20, 2023. It is now read-only.

Refactor nrn_setup.cpp #241

Closed
Closed

Description

@ohm314

Currently nrn_setup.cpp is a ~2300 line file with several very long, complicated functions (e.g. read_phase2). This code is very hard to understand and maintain. We need to:

  • get a clear understanding of all functions in this module
  • Split the function further down into smaller functions that do single simple operations
  • Simplify the code, make variable naming clearer, refactor to reduce code duplication

This will also be important for the rest of the refactoring as currently many of the data structures of coreneuron are touched here in the context of these functions and it is hard to rewrite the rest of the code ensuring that specifically in this location nothing breaks.

Activity

  1. added this to the NEURON v8.0 Release milestone on Jul 24, 2020
  2. alkino commented on Oct 22, 2020

    @alkino
    Member

    Fixed by #283

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions