Addrthread finish

[PeterSurda]

• addrthread is supposed to spread addresses as they appear. This was never
  finished during migration to asyncore
• conservative to prevent flood and loops
• randomises order
• see addrthread unfinished #1575

[g1itch]

So the AddrThread should periodically send addr messages to all connections?

[g1itch]

Also I don't understand Multiqueue ): for example _init() seems unused.

[PeterSurda]

So the AddrThread should periodically send addr messages to all connections?

kind of, it relays those received from others

[PeterSurda]

Also I don't understand Multiqueue ): for example _init() seems unused.

It's inherited from Queue.Queue and called from its own __init__: _init()

[PeterSurda]

In other words, with respect to Multiqueue, many calls are called from super, I just reimplement the internal methods. since Queue.Queue only has one deque(), whereas Multiqueue has several of them in a list and iterates over them.

[PeterSurda]

Thank you for the review, I made the changes except I put destination the last, after seenTime, so that the list for addrQueue and assemble_addr have the first three variables in the same order (addrQueue having a fourth at the end).

[g1itch]

I merged the branch and trying to connect to at least two nodes. It takes so long last time ):

[g1itch]

Seems working as expected

[PeterSurda]

I'm testing it on a public IP just to make sure there are no weird bandwidth spikes. I'll leave it for a couple of days.

[PeterSurda]

Testing doesn't reveal any unusual amount of traffic.