Repository navigation
Network Quality fixes 1 - #1554
Merged
Merged
Conversation
lakshyacis
force-pushed
the
fix#11
branch
4 times, most recently
from
November 18, 2019 13:44
7d4967d to
8984dcd
Compare
PeterSurda
reviewed
Nov 25, 2019
PeterSurda
reviewed
Nov 25, 2019
PeterSurda
reviewed
Nov 25, 2019
PeterSurda
reviewed
Nov 25, 2019
PeterSurda
reviewed
Nov 25, 2019
PeterSurda
reviewed
Nov 25, 2019
PeterSurda
reviewed
Nov 25, 2019
PeterSurda
requested changes
Nov 25, 2019
PeterSurda
left a comment
PeterSurda
left a comment
Member
There was a problem hiding this comment.
Please make the requested changes.
lakshyacis
force-pushed
the
fix#11
branch
3 times, most recently
from
November 25, 2019 13:41
ca671bd to
2216c60
Compare
PeterSurda
reviewed
Nov 25, 2019
Member
|
please remove |
PeterSurda
self-requested a review
November 25, 2019 14:30
PeterSurda
requested changes
Nov 25, 2019
PeterSurda
left a comment
PeterSurda
left a comment
Member
There was a problem hiding this comment.
Please make the requested changes
g1itch
reviewed
Nov 25, 2019
g1itch
reviewed
Nov 25, 2019
g1itch
reviewed
Nov 25, 2019
g1itch
reviewed
Nov 25, 2019
g1itch
reviewed
Nov 25, 2019
g1itch
reviewed
Nov 25, 2019
Collaborator
|
So inconsistent. I don't understand why do you
|
Contributor
Author
Actually, all the code quality stuff is done. So, I'm just looking for the files that needed fixes. That's why I edited plugins again and this PR contains unrelated modules. But I will remove unrelated modules from the PR and make a new PR for them. |
g1itch
reviewed
Dec 20, 2019
g1itch
reviewed
Dec 20, 2019
| @@ -50,16 +45,17 @@ | |||
| many of the difficult problems for you, making the task of building | |||
| sophisticated high-performance network servers and clients a snap. | |||
| """ | |||
Collaborator
There was a problem hiding this comment.
Why do you want to include license into the doc?
Contributor
Author
There was a problem hiding this comment.
I don't know about this, that's why I didn't remove. Should I remove that?
lakshyacis
force-pushed
the
fix#11
branch
2 times, most recently
from
December 26, 2019 07:24
497eb09 to
6df4150
Compare
lakshyacis
force-pushed
the
fix#11
branch
15 times, most recently
from
January 8, 2020 08:16
f178ae4 to
8eb4535
Compare
PeterSurda
requested changes
Jan 10, 2020
PeterSurda
left a comment
PeterSurda
left a comment
Member
There was a problem hiding this comment.
Please change the two docstrings I noted, otherwise ok.
PeterSurda
requested changes
Jan 10, 2020
PeterSurda
left a comment
PeterSurda
left a comment
Member
There was a problem hiding this comment.
Please add the license you removed from src/network/asyncore_pollchoose.py into LICENSE file in the project root, after the other file-specific licenses. Otherwise ok.
PeterSurda
requested changes
Jan 10, 2020
|
|
||
| THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDER ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||
|
|
||
| ======================================================================================================== |
Member
There was a problem hiding this comment.
you should indicate which file this refers to, like on lines 23 and 37
PeterSurda
approved these changes
Jan 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes based on flake8 and pylint.
Reduce line length| Suppressed warnings| Added docstrings.