Repository navigation
Fixed: Wait for lists to be populated. Closes #1335. - #1336
Closed
coffeedogs wants to merge 1 commit into
Closed
coffeedogs wants to merge 1 commit into
coffeedogs wants to merge 1 commit into
Conversation
coffeedogs
changed the title
PeterSurda
requested changes
Aug 23, 2018
PeterSurda
left a comment
PeterSurda
left a comment
Member
There was a problem hiding this comment.
These changes would prevent incoming connections being handled while known nodes is empty. Instead, keep the exception and break from the cycle in connectionpool or something like that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses two cases where non-deterministic initialisation may lead to lists being used by
randomchoice()before they have been populated. Arguably we should ensure the length of the list is sufficiently large since passing a list of one undermines the point ofrandomchoice()and we are relying on system peculiarities to choose a random item.However I would favour planning and implementing a more deterministic initialisation than we have currently (simple > complex > complicated).