Skip to content

asyncore_pollchoose import refactor #1381

Open

Description

@coffeedogs

src/network/asyncore_pollchoose.py could benefit from changes like this to imports, however it would imply importing errno directly which would require some refactoring of the file which is out of scope for the code_quality work which is already approved. This change was recommended by @g1itch

This issue is to ensure such refactoring is considered at some point.

Activity

  1. g1itch commented on Oct 31, 2018

    @g1itch
    Collaborator

    You can also use importlib to fool the lints, like here.

  2. PeterSurda commented on Oct 31, 2018

    @PeterSurda
    Member

    This is based on code which is originally included in python 2.7, someone patched it to add epoll and kqueue support and I made further changes.

    I don't remember exactly whether I added winsock handling fully, or just amended it based on my tests. I don't mind if it's changed, but it would need further testing and now's not the time for that.

  3. added this to the v0.7.0 milestone on Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions