Skip to content

Added ⚡ content to Glossary > Node - #794

Merged
sbddesign merged 13 commits into
BitcoinDesign:masterfrom
Bosch-0:lightning_node
Jul 11, 2022
Merged

sbddesign merged 13 commits into
BitcoinDesign:masterfrom
Bosch-0:lightning_node

Conversation

@Bosch-0

@Bosch-0 Bosch-0 commented Apr 29, 2022 •

Copy link
Copy Markdown
Collaborator

Added lightning node content to the Glossary > Node page

Closes #460

💻 Preview

@sbddesign sbddesign left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good additions. It's about time we get lightning on this page. I left grammar and style edits.

Nit: if we're going to continue referring to lightning nodes as routing, merchant, and payment nodes in the Guide, I feel like we should discuss unifying our visuals and keeping them consistent.

For example, take this PR and the new Liquidity page. We're both using the cloud for the merchant and the phone for the payments. They differ in that I am using the "node" icon for the routing node because it reminds me of a physical piece of hardware, whereas you are using it more generally to just mean "node".

What if instead of having the node icon in all your art, each one had a lightning icon?

Furthermore, if we continually show the cloud icon next to the merchant, are we implying a merchant is always in the cloud? This comment applies to my liquidity page as well.

Screen Shot 2022-05-03 at 11 56 34 AM

Screen Shot 2022-05-03 at 11 56 54 AM

Comment thread guide/how-it-works/node.md Resolved
Comment thread guide/how-it-works/node.md Resolved
Comment thread guide/how-it-works/node.md Resolved
Comment thread guide/how-it-works/node.md Resolved
Comment thread guide/how-it-works/node.md Resolved
Comment thread guide/how-it-works/node.md Resolved
Comment thread guide/how-it-works/node.md Resolved
Comment thread guide/how-it-works/node.md Resolved
Bosch-0 and others added 8 commits May 4, 2022 10:27
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
@Bosch-0

Bosch-0 commented May 4, 2022

Copy link
Copy Markdown
Collaborator Author

Ty, all good suggestions @sbddesign will address the images today

@GBKS

GBKS commented May 4, 2022

Copy link
Copy Markdown
Contributor

Some ideas for the images:

  • Routing node could have multiple arrows going in and out with varying thickness (indicating small and large channels and payments)
  • Merchant node could have multiple thin arrows going in (indicating many small incoming payments)
  • Payment node could have 1-2 thin arrows going out (indicating many small outgoing payments)

@pavlenex pavlenex left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really solid overview, my only remark is the differentiation between nodes hosted online by a third party (btcpay, voltage) and merchant nodes. I think nodes on a VPS were communicated so that it sounds like merchants use them, so there's an overlap, but if we clear out and differenciate things a bit more and mention that actual users run VPS nodes for various reasons, then the merchant node section can remain as it is.

Comment thread guide/how-it-works/node.md Outdated
A hosted node is when a user runs their own node on a trusted third-party server. This puts full trust in the third-party that they will not tamper with your block data. This also exposes your transaction history to them, which is a potential privacy risk.
Hosted nodes are run on third-party servers and are common with merchants using [BTCPay Server](https://btcpayserver.org/). While you have some degree of control over a hosted node, using a hosted node can expose your transaction history to the hosting provider and involves trusting them not to tamper with your transaction data.

[Greenlight](https://blockstream.com/lightning/greenlight/) and [Validating Lightning Signer (VLS)](https://gitlab.com/lightning-signer) are experimental ways to run a hosted lightning node whilst users keep custody of their private keys.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if Voltage.cloud could be a good thing to mention? Perhaps we can also add why people run nodes in the cloud (uptime, stability), but as you said, cons are security (especially for lightning).

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure if voltage is custodial, they claim otherwise but not sure how it works. I will err on the side of custodial for now. They aren't open source either, tried to focus on examples that where.

Added saome details about the pros of hosting nodes

Comment thread guide/how-it-works/node.md Resolved

</div>

### Merchant nodes

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me it was a bit confusing that "hosted VPS nodes paragraph" used merchants as an example, hence it's a bit of an overlap. Perhaps in the VPS nodes, we can actually say users run them when they want better uptime and stability, and also privacy (because they can run on clearnet without leaking the IP) where as merchant's nodes can remain with the existing text.

@Bosch-0
Bosch-0 requested review from pavlenex and sbddesign May 24, 2022 05:13
@sbddesign

Copy link
Copy Markdown
Collaborator

@Bosch-0 I found it really difficult to tell the difference between the new pictures. They all look very similar, and it took me a moment to figure out the differences.

Here's some alternate designs.
https://www.figma.com/file/VHbccy84a9ifaQrQ9v9lY5/Lightning-Node-Icons-for-Design-Guide?node-id=0%3A1

I still have merchant nodes listed as running on VPS on the Liquidity page because that's what my (very limited) data seems to indicate. If you're worried about misrepresenting and excluding physical merchant nodes, that's fine -- but perhaps we can find other ways to portray that it's a merchant's node.

@GBKS GBKS added Copy Task is about improving text. Design Task is about designing something. Glossary Referring to the Glossary section. labels May 30, 2022
@GBKS

GBKS commented Jul 5, 2022

Copy link
Copy Markdown
Contributor

What's needed to wrap this one up? Seems like it's just a few text edits and image updates?

For the images, maybe using the following to differentiate them might help:

  • Different amounts of arrows (routing has more than payment, etc)
  • Different colors for ingoing and outgoing
  • Turn payment node into a smartphone, indicating that it's more and end-user thing
  • Change merchant node to a point-of-sale graphic

@netlify

netlify Bot commented Jul 6, 2022 •

Copy link
Copy Markdown

✅ Deploy Preview for bitcoin-design-site ready!

Name Link
🔨 Latest commit 2eb5404
🔍 Latest deploy log https://app.netlify.com/sites/bitcoin-design-site/deploys/62cb9ebd05aeed000972a418
😎 Deploy Preview https://deploy-preview-794--bitcoin-design-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@GBKS

GBKS commented Jul 6, 2022

Copy link
Copy Markdown
Contributor

Here's a proposal for updated images (Figma). I combined the different node shapes in the Figma file linked above, adjusted the number of channels/arrows based on traffic, and used color for a little more contrast.

image

Comment thread guide/how-it-works/node.md Resolved
@sbddesign

Copy link
Copy Markdown
Collaborator

image

These look nice. I think it depends on which idea is most important.

  • Is more important to communicate the intended use-case of the nodes?
    • Go with my images
  • Is it more important to communicate the difference in liquidity?

@GBKS GBKS left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Images looking crisp now.

@Bosch-0
Bosch-0 requested a review from GBKS July 11, 2022 08:44

@sbddesign sbddesign left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@sbddesign
sbddesign merged commit 8275158 into BitcoinDesign:master Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Copy Task is about improving text. Design Task is about designing something. Glossary Referring to the Glossary section.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ⚡ content to Glossary > Node

4 participants