Skip to content

Add Non-recommended schemes to PKM overview - #579

Merged
GBKS merged 4 commits into
BitcoinDesign:masterfrom
Bosch-0:patch-39
Nov 30, 2021
Merged

GBKS merged 4 commits into
BitcoinDesign:masterfrom
Bosch-0:patch-39

Conversation

@Bosch-0

@Bosch-0 Bosch-0 commented Nov 24, 2021 •

Copy link
Copy Markdown
Collaborator

Preview

Closes #398

@pavlenex
pavlenex requested a review from danielnordh November 25, 2021 11:58
@GBKS GBKS added the Copy Task is about improving text. label Nov 26, 2021
@GBKS

GBKS commented Nov 26, 2021

Copy link
Copy Markdown
Contributor

ACK. Just one minor tweak. Wonder if this could be extracted to a sub-page of the glossary, so this page could stay simple.

@Bosch-0

Bosch-0 commented Nov 29, 2021

Copy link
Copy Markdown
Collaborator Author

@GBKS it's such a small addition I don't need it needs it's own page

Co-authored-by: Christoph Ono <chri@sto.ph>
@Bosch-0
Bosch-0 requested a review from GBKS November 29, 2021 05:36
Bosch-0 and others added 2 commits November 30, 2021 11:56
Co-authored-by: Pavlenex <pavle@pavle.org>
Co-authored-by: Pavlenex <pavle@pavle.org>
@Bosch-0
Bosch-0 requested a review from pavlenex November 30, 2021 03:56

@GBKS GBKS left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Good addition, so it doesn't look like we missed certain schemes.

@GBKS
GBKS merged commit e9793be into BitcoinDesign:master Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Copy Task is about improving text.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add non-recommended schemes to the private key section

3 participants