Skip to content

WIP: Private key management chapter - #48

Merged
johnsBeharry merged 233 commits into
masterfrom
private-key-management-v1
Dec 23, 2020
Merged

johnsBeharry merged 233 commits into
masterfrom
private-key-management-v1

Conversation

@danielnordh

@danielnordh danielnordh commented Nov 16, 2020 •

Copy link
Copy Markdown
Contributor

This is a working branch for the private key management chapter.

Edit
I now believe it is in good enough shape for an MVP, so ready for merging feedback!

@danielnordh danielnordh changed the title WIP: Private key management v1 WIP: Private key management chapter Nov 17, 2020
@danielnordh
danielnordh marked this pull request as draft November 17, 2020 09:39
@danielnordh danielnordh self-assigned this Nov 17, 2020
@GBKS

GBKS commented Dec 22, 2020

Copy link
Copy Markdown
Contributor

ACK. Reviewed yesterday and today and gave a lot of feedback. This is a fantastic first version we can put live. I found it super helpful to have these ideas clearly laid out.

A few ideas for follow-up tasks after merge that can be handled separately:

  • Are there more places to cross-link with other sections?
  • Can we consolidate or cross-reference some overlapping content in "Personal schemes" and "Personal finance"?
  • Diagrams in "Private key schemes" are too detailed for mobile and we can create alternate layouts for those screen sizes
  • When referencing products that implement certain techniques, is it helpful to show screenshots?
  • Should "Principles" be a separate section? Looks like @johnsBeharry and @ConorOkus are considering having similar section. Maybe wait until their content is further developed and then consolidate?

danielnordh and others added 25 commits December 22, 2020 15:19
Typo

Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Johns Beharry <johns@peakshift.com>
Co-authored-by: Johns Beharry <johns@peakshift.com>
Co-authored-by: Johns Beharry <johns@peakshift.com>
Co-authored-by: Johns Beharry <johns@peakshift.com>
Co-authored-by: Johns Beharry <johns@peakshift.com>
Co-authored-by: Johns Beharry <johns@peakshift.com>
Co-authored-by: Johns Beharry <johns@peakshift.com>
Co-authored-by: Johns Beharry <johns@peakshift.com>
@johnsBeharry
johnsBeharry merged commit 3ff7f62 into master Dec 23, 2020
@pavlenex

Copy link
Copy Markdown
Contributor

Congratulations on this ,seriously! 🚀 🚀 🎉

@danielnordh
danielnordh deleted the private-key-management-v1 branch May 11, 2021 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Copy Task is about improving text. Design Task is about designing something.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants