Skip to content

Fix for #190 - created artwork for Principles page - #453

Merged
pavlenex merged 5 commits into
BitcoinDesign:masterfrom
sbddesign:feature/principles-art
Aug 18, 2021
Merged

pavlenex merged 5 commits into
BitcoinDesign:masterfrom
sbddesign:feature/principles-art

Conversation

@sbddesign

Copy link
Copy Markdown
Collaborator

No description provided.

@sbddesign

Copy link
Copy Markdown
Collaborator Author

There's some alternate header designs in the Figma file if anyone is interested in seeing:
Figma File

@pavlenex

Copy link
Copy Markdown
Contributor

Visually, they look great! 😍

Do you think we should re-size them for example like we did here https://deploy-preview-453--sad-borg-390916.netlify.app/guide/designing-products/usage-life-cycle/#unaware ?

@johnsBeharry johnsBeharry left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbddesign awesome work man, love the style of these icons so much.

Comment thread Gemfile.lock Resolved
@sbddesign

Copy link
Copy Markdown
Collaborator Author

@pavlenex I made the images inline. It looked a little weird having the images inline with the paragraph text, so I customized it a little bit and made them sit next to the blockquotes.

@Bosch-0 Bosch-0 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I think the icons look better centered to the block quote. Currently they float slightly above.

image

@GBKS GBKS added the Design Task is about designing something. label Aug 17, 2021
@GBKS GBKS linked an issue Aug 17, 2021 that may be closed by this pull request
@pavlenex

Copy link
Copy Markdown
Contributor

Posting this comment from Christoph

I don't think the formatting with the block quotes next to the images work. How about using bold text instead of block quotes?

Which may solve the alignment problem we're having.

@sbddesign

Copy link
Copy Markdown
Collaborator Author

The above commit is an attempt to address feedback in this thread as well as in the discussion thread for #190.

@pavlenex pavlenex left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@pavlenex
pavlenex merged commit 373a528 into BitcoinDesign:master Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Design Task is about designing something.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Design Visuals for the Principles Section

5 participants