Skip to content

Fix various image-related minor issues on the coin selection page - #414

Merged
pavlenex merged 3 commits into
masterfrom
feature/coin-selection-image-fixes
Jun 30, 2021
Merged

pavlenex merged 3 commits into
masterfrom
feature/coin-selection-image-fixes

Conversation

@GBKS

@GBKS GBKS commented Jun 28, 2021 •

Copy link
Copy Markdown
Contributor

Addresses parts of #360.

Move images to the correct folder (they were in the glossary before).
Add proper alt descriptions.

Preview

@barefoot-88 could you please let me know where I can find the source for the page header image? The 2x version should be twice the size, and the 1x version 4x the size.

Move images to the correct folder (they were in the glossary before).
Add proper alt descriptions.
@GBKS GBKS added the Dev Development-focused tasks. label Jun 28, 2021
@GBKS GBKS self-assigned this Jun 28, 2021
@steady-eddie

Copy link
Copy Markdown
Contributor

Thanks @GBKS for pointing these out. Going to try and fix the issue now!

@GBKS
GBKS requested a review from johnsBeharry June 29, 2021 11:44

@johnsBeharry johnsBeharry left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good on the technical side, I'm happy to see git mv used instead of delete and add (less space used). Only thing missing is the editor notes which I think should be included in this PR as this one already deals with images.

@johnsBeharry

johnsBeharry commented Jun 29, 2021 •

Copy link
Copy Markdown
Contributor

@barefoot-88 I've invited you to a figma file where we can put all the graphics for the payments section. Do you mind moving your illustrations over to there? I don't know if this may cause issues with any components being detached from the master one though since its using the bitcoin ui kit.

Thoughts on the source files only using frames and groups instead of components @GBKS?

@pavlenex
pavlenex merged commit 8d1b44e into master Jun 30, 2021
@GBKS

GBKS commented Jun 30, 2021

Copy link
Copy Markdown
Contributor Author

@johnsBeharry feel free to open another PR with editors notes and source files whenever. Whether components are used or not is up to you. Some designs lend themselves well for components, others don't.

@GBKS GBKS mentioned this pull request Jul 1, 2021
5 tasks done
@danielnordh
danielnordh deleted the feature/coin-selection-image-fixes branch September 17, 2021 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dev Development-focused tasks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants