Skip to content

Fix various social preview images - #323

Merged
GBKS merged 2 commits into
masterfrom
feature/preview-image-fixes
May 18, 2021
Merged

GBKS merged 2 commits into
masterfrom
feature/preview-image-fixes

Conversation

@GBKS

@GBKS GBKS commented May 18, 2021

Copy link
Copy Markdown
Contributor

As found via: #245 (comment)

Addresses broken links and all pages where we have a page header image but either no preview image yet, or using a screenshot for the preview image (screenshots get quickly outdated).

@GBKS GBKS added the Design Task is about designing something. label May 18, 2021
@GBKS GBKS self-assigned this May 18, 2021
@GBKS GBKS mentioned this pull request May 18, 2021

@johnsBeharry johnsBeharry left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't be tested unless it's on production. So YOLO merge?

image

@GBKS

GBKS commented May 18, 2021

Copy link
Copy Markdown
Contributor Author

Yes, that's one of the issues. It's just a bunch of link preview images though, so not much risky (unless you're extremely risk intolerant).

@GBKS
GBKS merged commit fb4e83d into master May 18, 2021
@danielnordh
danielnordh deleted the feature/preview-image-fixes branch September 17, 2021 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Design Task is about designing something.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants