Skip to content

Created artwork for Sending Bitcoin page (fix for #207) - #296

Merged
pavlenex merged 5 commits into
BitcoinDesign:masterfrom
sbddesign:feature/sending-bitcoin-header
May 10, 2021
Merged

pavlenex merged 5 commits into
BitcoinDesign:masterfrom
sbddesign:feature/sending-bitcoin-header

Conversation

@sbddesign

Copy link
Copy Markdown
Collaborator

No description provided.

@GBKS

GBKS commented May 7, 2021

Copy link
Copy Markdown
Contributor

Looks awesome. To fulfill my duty as chief-image-nitpicker, I do have to point out that the image file names should have the "@2x" suffice for the retina version, and no suffix for the regular one, and that the social preview image should be a separate image with 1200x630px size.

@GBKS GBKS added the Design Task is about designing something. label May 7, 2021
@sbddesign

Copy link
Copy Markdown
Collaborator Author

I should have read the manual. Fixed.

pavlenex
pavlenex previously approved these changes May 8, 2021

@pavlenex pavlenex left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavlenex

pavlenex commented May 8, 2021

Copy link
Copy Markdown
Contributor

Closes #207

@GBKS

GBKS commented May 10, 2021

Copy link
Copy Markdown
Contributor

@sbddesign this one just needs a conflict resolve, then we can merge.

@pavlenex

Copy link
Copy Markdown
Contributor

Resolved the conflict on Stephen's behalf, let's get this beauty IN!

@Bosch-0 Bosch-0 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pavlenex
pavlenex merged commit 802b687 into BitcoinDesign:master May 10, 2021
@sbddesign
sbddesign deleted the feature/sending-bitcoin-header branch May 10, 2021 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Design Task is about designing something.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants