Repository navigation
Update guide.md #220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Update guide.md #220
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
2bc28b8
Update guide.md
pavlenex 38999d3
Apply suggestions from code review
pavlenex 4facd1f
Update guide.md
pavlenex d7ac828
Merge branch 'master' into kenedits
pavlenex 50ea16f
Update guide.md
pavlenex ae8f0c1
address capitalizaiton of Bitcoin
pavlenex a8fb4ac
re-base based on #248
pavlenex d232845
fix formatting
pavlenex a01e45a
revert case studies section
pavlenex File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The travel guide metaphor is visualized in the page header. So my vote would be for keeping it in the text as well. I also like the new copy, maybe combine the two?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the "map" is evident from it being called a guide and a map being at the top. Otherwise it's see/say. I have some doubts about the metaphor itself and suspect that it's clearer without.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you not like about the metaphor? It got a really strong positive response from people, which was a signal for me to put it in focus.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I liked the metaphor when we were describing the 'guide project'.
Now that I read/review the whole guide it feels we can be shorter in our writing in general.
Let people get to the content instead of describing what they will get. So I'm ok with moving on from the metaphor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tend to agree, I was the biggest fan of the metaphor but after reading a guide a bit myself, I completely agree with what Daniel is saying above. We need to be a bit more concise. How about we remove it, and if we feel nostalgic we can always return it or we can put it on GitHub somewhere, repo description or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consensus is to remove it, so let's go with that. Thanks for the input.