Skip to content

chore: remove .DS_Store, ignore windows+vim generated files - #15

Merged
pedromvpg merged 1 commit into
BitcoinDesign:masterfrom
johnsBeharry:hotfix/improve-gitignore
Aug 12, 2020
Merged

pedromvpg merged 1 commit into
BitcoinDesign:masterfrom
johnsBeharry:hotfix/improve-gitignore

Conversation

@johnsBeharry

Copy link
Copy Markdown
Contributor

Problem

  • .DS_Store files were committed to the repo
  • Windows, Linux and Vim auto-generated files can be committed by accident

Solution

  • cd BitcoinDesign/Guide && find . -name .DS_Store -print0 | xargs -0 git rm -f --ignore-unmatch
  • Add some standard rules to ignore Mac, Windows, and Linux autogenerated files

Result

  • No more .DS_Store files
  • Updated .gitignore

@johnsBeharry
johnsBeharry requested review from GBKS and pedromvpg August 6, 2020 20:41
@GBKS

GBKS commented Aug 12, 2020

Copy link
Copy Markdown
Contributor

@pedromvpg you're assigned here as a reviewer. Could you please take a look? The PR is about a minor cleanup, should just take a minute.

@pedromvpg
pedromvpg merged commit 136b79c into BitcoinDesign:master Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants