Repository navigation
Adds diagrams to the multi-key how it works page - #1064
Conversation
For issue #561. This adds diagrams for the multi-key page to explain more visually how a wallet is constructed and transactions signed, without going into too much technical detail.
✅ Deploy Preview for bitcoin-design-site ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I just realised this PR was only for the diagrams, and most of my inputs were about the text. |
|
The diagrams look great. Friendly and easy to understand. |
Combining multiple feedback points from GitHub.
Per GitHub feedback.
|
Thanks for the feedback. Since both of you had notes on the paragraph at line 83, I combined the changes and did not replay to your individual comments. Hope it reads better now. And ready for another round of review. |
yashrajd
left a comment
There was a problem hiding this comment.
The images are a great addition, and look great too.
Added a final couple items in feedback.
Co-authored-by: yashrajd <114083781+yashrajd@users.noreply.github.com>
|
Thanks for the feedback, I just accepted both changes. I wonder how consistent we are across the guide with terms like multi-sig vs multisig, blockchain vs block chain, etc. Bitcoin OpTech has a style guide that I refer to when in doubt. Not super urgent, but maybe something to revise at some point. |
|
Those diagrams are great. Super help for understanding the concept of exchanging keys. |
For issue #561. This adds diagrams for the multi-key page to explain more visually how a wallet is constructed and transactions signed, without going into too much technical detail.
If we like this type of diagram, I can also create variations for the other key management pages.
🛰️Check the preview🛸