Skip to content

Adds diagrams to the multi-key how it works page - #1064

Merged
GBKS merged 5 commits into
masterfrom
feature/multi-key-diagram
Jan 26, 2024
Merged

GBKS merged 5 commits into
masterfrom
feature/multi-key-diagram

Conversation

@GBKS

@GBKS GBKS commented Jan 15, 2024 •

Copy link
Copy Markdown
Contributor

For issue #561. This adds diagrams for the multi-key page to explain more visually how a wallet is constructed and transactions signed, without going into too much technical detail.

If we like this type of diagram, I can also create variations for the other key management pages.

🛰️Check the preview🛸

For issue #561. This adds diagrams for the multi-key page to explain more visually how a wallet is constructed and transactions signed, without going into too much technical detail.
@GBKS GBKS added Design Task is about designing something. How it works Referring to the How it works section. labels Jan 15, 2024
@GBKS GBKS self-assigned this Jan 15, 2024
@netlify

netlify Bot commented Jan 15, 2024 •

Copy link
Copy Markdown

✅ Deploy Preview for bitcoin-design-site ready!

Name Link
🔨 Latest commit 24d93e0
🔍 Latest deploy log https://app.netlify.com/sites/bitcoin-design-site/deploys/65b20f09a4224f0008d5b197
😎 Deploy Preview https://deploy-preview-1064--bitcoin-design-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@GBKS GBKS changed the title Adds a diagram to the multi-key how it works page Adds diagrams to the multi-key how it works page Jan 15, 2024
@yashrajd

Copy link
Copy Markdown
Contributor

I just realised this PR was only for the diagrams, and most of my inputs were about the text.

@rabbitholiness

Copy link
Copy Markdown
Collaborator

The diagrams look great. Friendly and easy to understand.

GBKS added 3 commits January 16, 2024 14:13
Combining multiple feedback points from GitHub.
@GBKS

GBKS commented Jan 24, 2024

Copy link
Copy Markdown
Contributor Author

Thanks for the feedback. Since both of you had notes on the paragraph at line 83, I combined the changes and did not replay to your individual comments. Hope it reads better now. And ready for another round of review.

@yashrajd yashrajd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The images are a great addition, and look great too.

Added a final couple items in feedback.

Co-authored-by: yashrajd <114083781+yashrajd@users.noreply.github.com>
@GBKS

GBKS commented Jan 25, 2024

Copy link
Copy Markdown
Contributor Author

Thanks for the feedback, I just accepted both changes.

I wonder how consistent we are across the guide with terms like multi-sig vs multisig, blockchain vs block chain, etc. Bitcoin OpTech has a style guide that I refer to when in doubt. Not super urgent, but maybe something to revise at some point.

@mouxdesign

Copy link
Copy Markdown
Collaborator

Those diagrams are great. Super help for understanding the concept of exchanging keys.
+1 for creating variations on other key management practices.

@GBKS
GBKS merged commit 1afdef2 into master Jan 26, 2024
@GBKS
GBKS deleted the feature/multi-key-diagram branch January 26, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Design Task is about designing something. How it works Referring to the How it works section.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants