You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Explore Github Pages for hosting the guide website #2
There are several advantages to hosting the site via Github pages:
Integrated with the Github collaboration tools
Automatically reflects the latest codebase without any complex deploy processes
Easy to configure due to Jekyll integration
Integration with third-party tools like Transifex for localization
There are some known basics we can already explore (templating, search function, localization), but we will have to wait for the content and design to progress further to really know what all of our requirements are. We can either keep this issue open, or focus it on the basics and create more issues for future improvements.
Still not going too much into design as I want to make sure this offers all the functionality we need and I also want to make sure we jumpstart the project with a more barebones/wireframy look and feel so the visual ui can emerge and evolve with the content of the guide.
I believe we can safely assume that everybody is on board with this proposal. I'll close this issue on Monday, July 27, if there are no further comments.
Happy to go with this, I would like us to look into if it's possible to do PR builds. So opening a pull request creates a "preview" version of the site so people reviewing can see the content on the site and not just in markdown.
@ConorOkus PR Commits can actually be easy if the forker has GitHub pages also enabled for their repo. Once the links resolve properly. Can be something added to the CONTRIBUTING.md
@pedromvpg that seems like feature by Netlify, no? So Github doesn't support it by default, but you can use Netlify to make it happen? Totally fine with me if that's the case.
Activity
pedromvpg commentedon Jul 12, 2020
Some more progress done here:
https://pedromvpg.github.io/bitcoin-design-guide/
More structure, homepage, search, and more.
Still not going too much into design as I want to make sure this offers all the functionality we need and I also want to make sure we jumpstart the project with a more barebones/wireframy look and feel so the visual ui can emerge and evolve with the content of the guide.
GBKS commentedon Jul 24, 2020
I believe we can safely assume that everybody is on board with this proposal. I'll close this issue on Monday, July 27, if there are no further comments.
ConorOkus commentedon Jul 24, 2020
Happy to go with this, I would like us to look into if it's possible to do PR builds. So opening a pull request creates a "preview" version of the site so people reviewing can see the content on the site and not just in markdown.
johnsBeharry commentedon Jul 24, 2020
@ConorOkus PR Commits can actually be easy if the forker has GitHub pages also enabled for their repo. Once the links resolve properly. Can be something added to the CONTRIBUTING.md
GBKS commentedon Jul 27, 2020
@johnsBeharry that only works for forks and not for branches, right?
pedromvpg commentedon Jul 27, 2020
I think it works with any PR: https://www.netlify.com/blog/2016/07/20/introducing-deploy-previews-in-netlify/
GBKS commentedon Jul 28, 2020
@pedromvpg that seems like feature by Netlify, no? So Github doesn't support it by default, but you can use Netlify to make it happen? Totally fine with me if that's the case.
Merge pull request #2 from johnsBeharry/patch-2
GBKS commentedon Oct 21, 2020
Pretty sure we can consider this one done for now. We are using Github Pages. Any changes can be discussed in new issues.
Merge pull request #2 from BitcoinDesign/master