Repository navigation
fix(wasm-dot): validate SS58 destination network prefixes - #407
Draft
ralph-bitgo[bot] wants to merge 1 commit into
Draft
ralph-bitgo[bot] wants to merge 1 commit into
ralph-bitgo[bot] wants to merge 1 commit into
Conversation
Validate recipient, payee, proxy, and self-transfer address prefixes before producing call data. Propagate an explicit generic-prefix policy through material and parser contexts, and cover mismatch regressions. Wallet approvals must not accept addresses labeled for another network then silently sign their AccountId in the selected chain. Ticket: WCN-1892 Session-Id: 4408559a-0119-4900-9471-eb853265da1b Task-Id: 3702a6ad-95cc-435a-8085-81d167f61534
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
Test plan
git diff --check origin/master...HEAD(passed; no whitespace errors).cargo test --manifest-path packages/wasm-dot/Cargo.toml— blocked:cargoandrustcare unavailable in this workspace.cargo fmt --manifest-path packages/wasm-dot/Cargo.toml -- --check— blocked:cargois unavailable.npm test --prefix packages/wasm-dotandnpm run build:ts --prefix packages/wasm-dot— blocked:node/npm, packagenode_modules, and generatedjs/wasm/wasm_dot.jsare absent.npm run build:wasm --prefix packages/wasm-dot— blocked:wasm-pack,cargo, andrustcare unavailable.Ticket: WCN-1892